Example quickstart not currently noop due to cpe_chrome and cpe_screensaver defaults

[arubdesu]

In the readme I think it should be clearly stated what changes are expected to happen. Applying the default quickstart.json results in two profiles appearing, for managing screensaver and chrome, which I think should be no-op by default. Un-intuitively, no munki changes occur, so it's extra confusing.

Muting this behavior for chrome requires adding this to IT-CPE/chef/cookbooks/cpe_init/recipes/company_init.rb:

node.default['cpe_chrome']['profile'] = {}
I don't know how to nerf cpe_screensaver...

While we're discussing the readme, I'd also spell out the chef-zero --local-mode and --override-runlist flags for the non-savvy.

[erikng]

I do agree that both cpe_screensaver and cpe_chrome should not setup defaults. I've worked around both of these but it may not be obvious to others. That said, when these were open sourced, these finer details may have been missed. Thanks, Erik Gomez

…

________________________________ From: Allister Banks <notifications@github.com> Sent: Tuesday, July 4, 2017 5:12:05 PM To: facebook/IT-CPE Cc: Subscribed Subject: [facebook/IT-CPE] Example quickstart not currently noop due to cpe_chrome and cpe_screensaver defaults (#93) In the readme<https://github.com/facebook/IT-CPE/blob/master/chef/README.md> I think it should be clearly stated what changes are expected to happen. Applying the default quickstart.json results in two profiles appearing, for managing screensaver and chrome, which I think should ne noop by default. Un-intuitively, no munki changes occur, so it's extra confusing. Muting this behavior for chrome requires adding this to IT-CPE/chef/cookbooks/cpe_init/recipes/company_init.rb: node.default['cpe_chrome']['profile'] = {} I don't know how to nerf cpe_screensaver... While discussing the readme, I'd spell out the chef-zero --local-mode and --override-runlist flags for the non-savvy. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#93>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFa_GMeiGr-8j9O_eMGawAjz2udrAolBks5sKri1gaJpZM4ONte5>.

[mikedodge04]

For the screen saver piece of it
#133

[mikedodge04]

For the chrome piece of it
#134

[mikedodge04]

Fixed with attached PRs