Unable to select nodes in way after adding to relation

[atiannicelli]

Description

There seems to be a couple different scenarios where I get into a situation where I have a way that I can't select the nodes for that way. This makes it impossible to edit the shape of the way. I have attached one such reproducible situation that I hope will be enough to describe the issue.

Version

2.0.3

What browser are you seeing the problem on? What version are you running?

Chrome v114.0

The OS you're using

mac

Steps to reproduce

As stated in the video, first I find a relation with many members. Then I draw an area that is attached to one of the members (actually it might not need to be attached). Then I add that new way into the relation. After that point I loose the ability to select the nodes of that way.

Screen.Recording.2023-06-30.at.9.39.05.AM.mov

The browser URL at the time you encountered the bug

https://rapideditor.org/rapid#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&map=19.98/39.57012/-75.97363

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36

[Bonkles]

This one is in process, and it is a seemingly gnarly bit of code where we calculate a selected way's descendant nodes. For some reason, only the midpoints are showing up as descendants, so that's what we render.

I can reproduce this without physically attaching the polygon to the relation, too.

[Bonkles]

My my! That took a bit.

Each render pass, we render polygons.

Each time we render polygons, we see which ones have changed and then refresh their data and any of the data of children (nodes inside ways, ways inside relations, etc). This involves clearing some data and reconstructing it.

In one very specific case, when we were clearing ways from the relation, we were accidentally ALSO deleting the render pipeline's node data for the way. The renderer lost those nodes UNTIL such time we forced the pipeline to recognize that the way's geometry was changed or updated (you could fix the problem by dragging a midpoint, then undoing).

[atiannicelli]

Awesome! Sorry to have made you go down such a rabbit hole!