Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py-tx] Implement NCMEC Upvote/Downvote in reference API #1648

Merged
merged 10 commits into from
Oct 3, 2024

Conversation

Dcallies
Copy link
Contributor

@Dcallies Dcallies commented Oct 3, 2024

Summary

Building on top of #1624 by @aryzle:

  1. Remove untyped dicts and use dataclass objects
  2. Deal with some weird tricky cases with parsing feedback

Test Plan

updated unittests
querying lookup against test_NGO api, and saw gets work.

Will make another pass on upvote/downvote, not sure if it works yet.

@Dcallies Dcallies changed the title [py-tx] NCMEC Feedback [py-tx] Implement NCMEC Upvote/Downvote in reference API Oct 3, 2024
@Dcallies Dcallies merged commit b75cd06 into facebook:main Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants