[buildfile] includes doesn't act like include_defs

[saadfarooq]

The documentation says that the includes property in the [buildfile] section of .buckconfig is equivalent to invoking include_defs at the start of each file.

However, when I include the following in a BUCK file it works fine but if I include it (via a file) in .buckconfig, it gives an error on the sha1 line.

include_defs('//bucklets/maven_jar.bucklet')
maven_jar(
  name = 'junit',
  id = 'junit:junit:4.11',
  sha1 = '4e031bb61df09069aeb2bffb4019e7a5034a4ee0'
)

Is this expected behavior ?

[davido]

It mostly works. This was already reported and tracked in #182. According to comments there, this bug was already fixed and the fix about to land shortly.

[saadfarooq]

Cool. Thanks.

[davido]

I probably misread your bug report, but this is unusually that you observe failure on sha1 line. I think exact your setting is up and running in gitiles project. Try pull and bulid it with buck build all and see how it's different from your case: [1]. Note, that gitile is using bucklet as submodule.

[1] git clone https://gerrit.googlesource.com/gitiles

[davido]

So this works: include this lines in .buckconfig :

[buildfile]
  includes = //bucklets.defs

And put this in bucklet.defs:

$ cat bucklets.defs
import os
import sys

d = os.getcwd()
while not os.path.lexists(os.path.join(d, '.buckversion')):
  d = os.path.dirname(d)

bd = os.path.join(d, 'bucklets')
if not os.path.isdir(bd) or not os.listdir(bd):
  sys.stderr.write(('Bucklets directory is missing or empty: %s\n'
                    'Run `git submodule update --init`') % bd)
  sys.exit(1)

bucklets = [
  'java_doc.bucklet',
  'java_sources.bucklet',
  'maven_jar.bucklet',
  'maven_package.bucklet',
  'war.bucklet',
]

for bucklet in bucklets:
  path = os.path.join(bd, bucklet)
  if not os.path.isfile(path):
    sys.stderr.write('Missing bucklet: %s\n' % path)
    sys.exit(1)
  include_defs('//bucklets/%s' % bucklet)

And now you don't need any more to include bucklets directly in you BUCK file, but should be able to just say:

maven_jar(
  name = 'junit',
  id = 'junit:junit:4.11',
  sha1 = '4e031bb61df09069aeb2bffb4019e7a5034a4ee0'
)

Or better say this to reflect hamcrest deps as well:

maven_jar(
  name = 'junit',
  id = 'junit:junit:4.11',
  sha1 = '4e031bb61df09069aeb2bffb4019e7a5034a4ee0',
  deps = [':hamcrest-core'],
)

maven_jar(
  name = 'hamcrest-core',
  id = 'org.hamcrest:hamcrest-core:1.3',
  sha1 = '42a25dc3219429f0e5d060061f71acb49bf010a0',
  visibility = ['//lib:junit'],
)

[saadfarooq]

That works. Thanks.
One comment though. The while not keeps looping forever if there is no `.buckversion' file.

[davido]

Thanks for reporting. Change under review [1].

[1] https://gerrit-review.googlesource.com/60264