Fix attribute spec for prebuilt_cxx_library_group include_dirs #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58759513 |
|
This pull request was exported from Phabricator. Differential Revision: D58759513 |
MatzeB
added a commit
to MatzeB/buck2
that referenced
this pull request
Jun 20, 2024
…ook#689) Summary: X-link: facebook/buck2-prelude#17 Pull Request resolved: facebook#689 Should allow directories here. Reviewed By: luciang Differential Revision: D58759513
MatzeB
added a commit
to MatzeB/buck2-prelude
that referenced
this pull request
Jun 20, 2024
…ook#17) Summary: Pull Request resolved: facebook#17 X-link: facebook/buck2#689 Should allow directories here. Reviewed By: luciang Differential Revision: D58759513
…ook#689) Summary: X-link: facebook/buck2-prelude#17 Pull Request resolved: facebook#689 Should allow directories here. Reviewed By: luciang Differential Revision: D58759513
MatzeB
added a commit
to MatzeB/buck2-prelude
that referenced
this pull request
Jun 20, 2024
…ook#17) Summary: Pull Request resolved: facebook#17 X-link: facebook/buck2#689 Should allow directories here. Reviewed By: luciang Differential Revision: D58759513
|
This pull request was exported from Phabricator. Differential Revision: D58759513 |
facebook-github-bot
pushed a commit
to facebook/buck2-prelude
that referenced
this pull request
Jun 21, 2024
Summary: Pull Request resolved: #17 X-link: facebook/buck2#689 Should allow directories here. Reviewed By: luciang Differential Revision: D58759513 fbshipit-source-id: fa1ae67ca54fee89de72afee3044befece594697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Should allow directories here.
Reviewed By: luciang
Differential Revision: D58759513