-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(create-react-app): assert for exit code #10973
Merged
Merged
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
force-pushed
the
test/integration
branch
from
May 31, 2021 07:48
79cf5b6
to
dbbccd9
Compare
jamesgeorge007
force-pushed
the
test/integration
branch
from
October 8, 2021 20:12
dbbccd9
to
de45f5c
Compare
mrmckeb
approved these changes
Oct 12, 2021
Looks great, thanks @jamesgeorge007! |
This was referenced Apr 12, 2022
This was referenced Jul 25, 2022
This was referenced Aug 26, 2022
This was referenced Nov 29, 2022
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at updating the CRA integration test suite to introduce assertions on exit codes.