Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webpack double error filtering hack #1755

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@sidoshi
Copy link
Contributor

commented Mar 7, 2017

Changes verified by running this commands:

npm run create-react-app test-app
cd test-app
npm start

created a syntax error in App.js.
Error is not duplicated after removing the hack

@gaearon

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

Can you check which version of webpack removed the need for the hack? Just to be sure.

@gaearon gaearon added this to the 0.10.0 milestone Mar 7, 2017

@gaearon

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

Note to self or @Timer: this will be a breaking change for react-dev-utils since we remove the workaround and technically people on older webpacks will have worse output.

@sidoshi

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2017

@gaearon

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

Interestingly, this hack may also be the reason for this disparity:

screen shot 2017-03-08 at 9 45 43 pm

screen shot 2017-03-08 at 9 45 51 pm

In this case I actually like the de-duplication and I wish it also happened in the terminal. We should probably investigate this a little bit more.

@gaearon

This comment has been minimized.

Copy link
Member

commented May 11, 2017

Hey! I'm very sorry—I totally forgot about this PR and removed this part independently in #2113.

My observation in #1755 (comment) kept me from merging this, so I also did #2125 as a followup to avoid this problem.

I appreciate your help with this though!

@gaearon gaearon closed this May 11, 2017

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.