remove webpack double error filtering hack #1755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check which version of webpack removed the need for the hack? Just to be sure. |
|
Note to self or @Timer: this will be a breaking change for |
|
Interestingly, this hack may also be the reason for this disparity:
In this case I actually like the de-duplication and I wish it also happened in the terminal. We should probably investigate this a little bit more. |
|
Hey! I'm very sorry—I totally forgot about this PR and removed this part independently in #2113. My observation in #1755 (comment) kept me from merging this, so I also did #2125 as a followup to avoid this problem. I appreciate your help with this though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes verified by running this commands:
npm run create-react-app test-appcd test-appnpm startcreated a syntax error in App.js.
Error is not duplicated after removing the hack