Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize configuration settings #176

Closed
wants to merge 1 commit into from
Closed

Centralize configuration settings #176

wants to merge 1 commit into from

Conversation

coryhouse
Copy link
Contributor

No description provided.

@ghost ghost added the CLA Signed label Jul 25, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 25, 2016

I’m 👍 on the intention but we have a conflicting PR #101 that we’d like to get in first.
Let’s revisit any refactorings after it.

@gaearon
Copy link
Contributor

gaearon commented Jul 25, 2016

I’ll close for now because we can do stylistic refactoring later, after (or as part of) shipping features.
Thanks for the PR though, and we’d love to see you contribute in the future.

@gaearon gaearon closed this Jul 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryhouse @gaearon