Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Auto-detect running editor on Windows for error overlay #2552
I decided to go with an a bit different approach for Windows than on macOS. This resolves the first two issues mentioned below.
The new approach detects only by the file name and re-uses the whole path found in the process list to launch the editor. On macOS this was not possible because some executables did not match the command needed to run (if I understood that right).
Regarding the third one:
Tested on Windows 10 with latest VS Code, Atom and Sublime Text 3.
The original content of this PR:
Also you can find the previous code here: levrik/create-react-app@adee1d0
referenced this pull request
Jun 18, 2017
This sounds good to try in a separate PR if you'd like!
Fixed in 1.0.8. Please verify.