Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint 4 #2735

Merged
merged 5 commits into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@trungdq88
Copy link
Contributor

commented Jul 6, 2017

Changes

  • Upgrades eslint-loader from 1.7.1 -> 1.9.0.
  • Add eslintPath option to eslint-loader
  • Upgrades ESLint from 3.19.0 to 4.1.1
  • Upgrades the unmet dependencies of ESlint 4.1.1.

Resolve related issues: #2528, #2604, #2631

Tested with issue #2528, verify with following script:

npm run create-react-app verify-issue-2528
cd verify-issue-2528
yarn add eslint
vim src/App.js # Add prop types to App.js

#  static propTypes = {
#    aoeu: React.PropTypes.any,
#  }

yarn run build # Should build success :tada:

Screenshot

image

Tests

Passed: https://travis-ci.org/trungdq88/create-react-app/builds/250878659

@trungdq88 trungdq88 referenced this pull request Jul 6, 2017

Closed

ESLint 4 #2644

@@ -142,6 +142,7 @@ module.exports = {
},
ignore: false,
useEslintrc: false,
eslintPath: require.resolve('eslint'),

This comment has been minimized.

Copy link
@gaearon

gaearon Jul 6, 2017

Member

We should probably move this outside of @remove-on-eject.

@@ -144,6 +144,7 @@ module.exports = {
},
ignore: false,
useEslintrc: false,
eslintPath: require.resolve('eslint'),

This comment has been minimized.

Copy link
@gaearon

gaearon Jul 6, 2017

Member

Same.

@gaearon gaearon added this to the 1.0.11 milestone Jul 7, 2017

@gaearon

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

I think this looks good. Thank you!

@gaearon gaearon merged commit bbbc15d into facebook:master Jul 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

ESLint 4 (facebook#2735)
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017

ESLint 4 (#2735)
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

ESLint 4 (facebook#2735)
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017

ESLint 4 (#2735)
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject

kasperpeulen added a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017

ESLint 4 (facebook#2735)
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject

swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017

ESLint 4 (#2735)
* Update eslint-loader 1.7.1 -> 1.9.0

* Add eslintPath option

* Update eslint 3.19.0 -> 4.1.1

* Update peer dependencies

* Move eslintPath config to outside @remove-on-eject

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.