Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export dismissRuntimeErrors function #3414

Merged
merged 1 commit into from
Nov 5, 2017
Merged

Export dismissRuntimeErrors function #3414

merged 1 commit into from
Nov 5, 2017

Conversation

ovidiuch
Copy link
Contributor

@ovidiuch ovidiuch commented Nov 5, 2017

Context from react-cosmos/react-cosmos#484 (comment)

@skidding thinking of programmatically closing runtime error overlay in some cases. I noticed there's a dismissRuntimeErrors function but it isn't exported. Do you see any reasons why it shouldn't be called? Otherwise I'd like to submit a PR for exporting it.

@Timer Mainly because in our use case it doesn't make sense to dismiss. Happy to accept a pull request exporting it.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ovidiuch
Copy link
Contributor Author

ovidiuch commented Nov 5, 2017

FYI, I noticed this at the end of a green AppVeyor build (nodejs_version=8, test_suite=simple):

Creating an optimized production build...
Failed to compile.
Module not found: Error: You attempted to import ../sample which falls outside of the project src/ directory. Relative imports outside of src/ are not supported. You can either move it inside src/, or add a symlink to it from project's node_modules/.

@Timer
Copy link
Contributor

Timer commented Nov 5, 2017

That error is intentional and we're checking that it's thrown. :)

@Timer
Copy link
Contributor

Timer commented Nov 5, 2017

Thanks for this!

@Timer Timer merged commit 5b4ff56 into facebook:master Nov 5, 2017
@Timer Timer added this to the 1.0.17 milestone Nov 5, 2017
@ovidiuch ovidiuch deleted the export-dismiss-overlay-function branch November 6, 2017 09:24
@ovidiuch
Copy link
Contributor Author

ovidiuch commented Nov 6, 2017

Thanks for this!

Likewise!

@ovidiuch
Copy link
Contributor Author

Any idea when this will be published? Looking forward to using dismissRuntimeErrors in Cosmos ✌️

@Timer
Copy link
Contributor

Timer commented Nov 26, 2017

I'm not sure when we're cutting the next release, but it's on my list to remind you when we do!

We can probably try to get one done soon, even if just the overlay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants