Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proxy for all request methods other than GET #3726

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
4 participants
@sidoshi
Copy link
Contributor

sidoshi commented Jan 9, 2018

I created a new app and verified that all the requests that do not have GET method get proxied.

Fixes #3311

@gaearon gaearon added the tag: bug fix label Jan 9, 2018

@gaearon gaearon added this to the 1.0.18 milestone Jan 9, 2018

@gaearon

This comment has been minimized.

Copy link
Member

gaearon commented Jan 9, 2018

Seems reasonable to me.

@Timer any objections?

@Timer

This comment has been minimized.

Copy link
Collaborator

Timer commented Jan 9, 2018

I don't see a problem.

Can you please add a comment explaining why so we remember in the future?

@gaearon gaearon merged commit 0ec4135 into facebook:master Jan 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaearon gaearon referenced this pull request Jan 15, 2018

Merged

Changelog for 1.1.0 #3795

tabrindle added a commit to tabrindle/create-react-app that referenced this pull request Jan 18, 2018

Use proxy for all request methods other than GET (facebook#3726)
* Use proxy for all request methods other than GET

* Add comment

Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018

Use proxy for all request methods other than GET (facebook#3726)
* Use proxy for all request methods other than GET

* Add comment

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.