Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close <br> tags in templates' READMEs #7668

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Close <br> tags in templates' READMEs #7668

merged 2 commits into from
Sep 30, 2019

Conversation

rakannimer
Copy link
Contributor

Parsing create-react-app generated READMEs with a MDX parser causes an error

SyntaxError: unknown: Expected corresponding JSX closing tag for <br>

This fixes it without affecting previous versions.

Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning makes sense on this one, thanks @rakannimer!

@mrmckeb mrmckeb merged commit c0d73ba into facebook:master Sep 30, 2019
@lock lock bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants