Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix light background in docusaurus night mode #7936

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

heyimalex
Copy link
Contributor

Closes #7930

Tested with the manual toggle, and with setting prefers-color-scheme. Not sure if there's a cleaner way to do this, but it works.

@andriijas andriijas added this to the 3.3 milestone Nov 6, 2019
@ahtee
Copy link

ahtee commented Nov 7, 2019

Looks good! thanks @heyimalex 🥇

@andriijas andriijas merged commit 30b491b into facebook:master Nov 13, 2019
@ahtee
Copy link

ahtee commented Nov 14, 2019

Will this change be active on next release? The live site currently isn't showing the changes from this PR.

@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode doesn't darken "Get started in seconds" section
5 participants