Add support for private debug info #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D47448961 |
bemasc
added a commit
to bemasc/dns
that referenced
this pull request
Jul 31, 2023
Summary: Pull Request resolved: facebook#43 This change adds an encrypted section called "private" to the debug TXT records and NSID output, containing information (such as the internal hostname) that may not be appropriate to disclose publicly. This is an alternative to D47304715. Reviewed By: yarikk Differential Revision: D47448961 fbshipit-source-id: 48eda13e347e433a8c82cb734b5aff6933a59b46
|
This pull request was exported from Phabricator. Differential Revision: D47448961 |
Summary: Pull Request resolved: facebook#43 This change adds an encrypted section called "private" to the debug TXT records and NSID output, containing information (such as the internal hostname) that may not be appropriate to disclose publicly. This is an alternative to D47304715. Reviewed By: yarikk Differential Revision: D47448961 fbshipit-source-id: 3872f6f1386b878fa347e601a9cac2a20a5ead8f
|
This pull request was exported from Phabricator. Differential Revision: D47448961 |
|
This pull request has been merged in d05f87e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds an encrypted section called "private" to the debug TXT records and NSID output, containing information (such as the internal hostname) that may not be appropriate to disclose publicly.
This is an alternative to D47304715.
Reviewed By: yarikk
Differential Revision: D47448961