rocksdb: remove MacOS-specific options #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: No need to keep a copy of MacOS-specific options.go just to have `ulong` replaced with `ulonglong`. Use universal `size_t` and `uint64_t` instead Reviewed By: deathowl Differential Revision: D51027976
|
This pull request was exported from Phabricator. Differential Revision: D51027976 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 58.91% 59.18% +0.27%
==========================================
Files 72 79 +7
Lines 8316 8651 +335
==========================================
+ Hits 4899 5120 +221
- Misses 3098 3209 +111
- Partials 319 322 +3 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 2da5c5b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: No need to keep a copy of MacOS-specific options.go just to have
ulongreplaced withulonglong. Use universalsize_tanduint64_tinsteadReviewed By: deathowl
Differential Revision: D51027976