use rocksdb WaitForCompact() #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Use latest and greatest `WaitForCompact()` that was added on our request instead of polling for compaction stats. Reviewed By: deathowl Differential Revision: D48355674 fbshipit-source-id: bc84db753348cfef535b82e01e60c125315b49a2
|
This pull request was exported from Phabricator. Differential Revision: D48355674 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
===========================================
+ Coverage 35.51% 58.98% +23.46%
===========================================
Files 17 79 +62
Lines 1799 8641 +6842
===========================================
+ Hits 639 5097 +4458
- Misses 1119 3228 +2109
- Partials 41 316 +275
☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in ff1272d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use latest and greatest
WaitForCompact()that was added on our request instead of polling for compaction stats.Reviewed By: deathowl
Differential Revision: D48355674