fix(v2): remove invalid attributes of nav links (#1974)

* fix(v2): remove nav links invalid attributes * Refactor: add remaining props
facebook · Nov 13, 2019 · 95e9963 · 95e9963
1 parent ffa6b71
commit 95e9963
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/Navbar/index.js b/packages/docusaurus-theme-classic/src/theme/Navbar/index.js
@@ -21,23 +21,23 @@ import useTheme from '@theme/hooks/useTheme';
 
 import styles from './styles.module.css';
 
-function NavLink(props) {
-  const toUrl = useBaseUrl(props.to);
+function NavLink({to, href, label, position, ...props}) {
+  const toUrl = useBaseUrl(to);
   return (
     <Link
       className="navbar__item navbar__link"
-      {...props}
-      {...(props.href
+      {...(href
         ? {
             target: '_blank',
             rel: 'noopener noreferrer',
-            href: props.href,
+            href,
           }
         : {
             activeClassName: 'navbar__link--active',
             to: toUrl,
-          })}>
-      {props.label}
+          })}
+      {...props}>
+      {label}
     </Link>
   );
 }