fix(v2): remove invalid attributes of nav links #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit a4bb6cd |
|
Deploy preview for docusaurus-preview ready! Built with commit a4bb6cd |
lex111
force-pushed
the
fix-header-attrs
branch
from
5e59053
to
a4bb6cd
Compare
endiliey
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, because that all props are passed to
NavLink, navigation links have two invalid attributes -labelandposition.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Before:
After: