Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown links inside comments shouldn't be resolved #6160

Closed
4 of 7 tasks
slorber opened this issue Dec 22, 2021 · 4 comments
Closed
4 of 7 tasks

Markdown links inside comments shouldn't be resolved #6160

slorber opened this issue Dec 22, 2021 · 4 comments
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: duplicate This issue or pull request already exists in another issue or pull request

Comments

@slorber
Copy link
Collaborator

slorber commented Dec 22, 2021 •
edited
Loading

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

When using HTML comments inside markdown files, and these comments contain markdown links, our system still tries to resolve those links.

See also #6159

[WARNING] Docs markdown link couldn't be resolved: (./api/lifecycle-apis.md) in /Users/sebastienlorber/Desktop/projects/docusaurus/website/versioned_docs/version-2.0.0-beta.13/using-themes.md for version 2.0.0-beta.13

Steps to reproduce

# MyDoc

<!--

[bad markdown link](./does-not-exist.md)

-->

Expected behavior

no warning

Actual behavior

produces a warning

Your environment

latest

Reproducible demo

No response

Self-service

  • I'd be willing to fix this bug myself.
@slorber slorber added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Dec 22, 2021
@slorber
Copy link
Collaborator Author

slorber commented Dec 22, 2021

Slightly related to #6108

@slorber slorber changed the title Trying to resolve markdown links inside comments Markdown links inside comments are resolved Dec 22, 2021
@slorber slorber changed the title Markdown links inside comments are resolved Markdown links inside comments shouldn't be resolved Dec 22, 2021
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Dec 22, 2021
@Josh-Cena
Copy link
Collaborator

Duplicate of #5659 😄

@Josh-Cena Josh-Cena added the closed: duplicate This issue or pull request already exists in another issue or pull request label Dec 22, 2021
@Josh-Cena
Copy link
Collaborator

And that's why I started working on #5670

@slorber
Copy link
Collaborator Author

slorber commented Dec 22, 2021

😆 I was pretty sure this already came up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution closed: duplicate This issue or pull request already exists in another issue or pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slorber @Josh-Cena