Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): remove invalid attr from mobile nav links #2765

Merged
merged 2 commits into from May 18, 2020
Merged

fix(v2): remove invalid attr from mobile nav links #2765

merged 2 commits into from May 18, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 17, 2020

Motivation

From Rocket Validator:

Attribute “position” not allowed on element “a” at this point. Found 600 times on this site.

Example:

"ist-item"><a target="_blank" rel="noopener noreferrer" href="https://github.com/facebook/docusaurus" class="menu__link header-github-link" position="right" aria-label="GitHub repository"></"

Result of regression from #2487.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Check a11y on preview website.

Related PRs

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label May 17, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 17, 2020
@lex111 lex111 requested a review from yangshun May 17, 2020 22:14
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented May 17, 2020 •
edited

Deploy preview for docusaurus-2 ready!

Built with commit 3d31976

https://deploy-preview-2765--docusaurus-2.netlify.app

yangshun
yangshun approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the unused prop linter (if we ever had one) will flag this and the next person who sees it will remove it. Need to add some comment here.

@yangshun yangshun merged commit 48b2b75 into master May 18, 2020
@yangshun yangshun deleted the lex111/remove-position-attr-mobile-item branch May 18, 2020 03:34
@lex111 lex111 added this to the v2.0.0-alpha.55 milestone May 19, 2020
@lex111 lex111 mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
v2.0.0-alpha.55
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lex111 @docusaurus-bot @yangshun @facebook-github-bot