Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(v2): improve regex matching code-block title" #3681

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 4, 2020

@lex111 lex111 requested a review from slorber as a code owner November 4, 2020 09:51
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 4, 2020
@lex111
Copy link
Contributor Author

lex111 commented Nov 4, 2020

@slorber I cannot merge this PR as I do not have write access still, so accept this PR asap.

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 2e44116

https://deploy-preview-3681--docusaurus-2.netlify.app

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 4, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 4, 2020

thanks :'(

didn't know it would fail on Safari

@slorber slorber merged commit 7c7e0c2 into facebook:master Nov 4, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://v2.docusaurus.io does not load correctly on Safari for Mac or iOS
4 participants