Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix website scripts on Windows by using cross-env #3693

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Nov 5, 2020

Motivation

V2 website scripts in current form do not work on Windows:

Screenshot 2020-11-05 142647

This PR fixes that problem by utilizing the cross-env package.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Changes has been tested on Windows and macOS device.

Related PRs

No.

@Simek Simek requested a review from slorber as a code owner November 5, 2020 13:37
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 5, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 5, 2020

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 95a198b

https://deploy-preview-3693--docusaurus-2.netlify.app

@Simek Simek changed the title fix(website): fix website scripts on Windows by using cross-env docs(v2): fix website scripts on Windows by using cross-env Nov 5, 2020
@slorber slorber changed the title docs(v2): fix website scripts on Windows by using cross-env fix(v2): fix website scripts on Windows by using cross-env Nov 5, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Nov 5, 2020
@slorber
Copy link
Collaborator

slorber commented Nov 5, 2020

make sense thanks

@slorber slorber merged commit 574af1f into facebook:master Nov 5, 2020
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants