fix(v2): Algolia: allow contextualSearch + facetFilters #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 9931a40 |
|
Size Change: +21 B (0%) Total Size: 154 kB ℹ️ View Unchanged
|
lex111
reviewed
Nov 23, 2020
|
Deploy preview for docusaurus-2 ready! Built with commit 17e38d3 |
|
Yes @lex111 , was actually going to fill an issue because the search page does not respect Algolia site config |
lex111
approved these changes
Nov 23, 2020
This was referenced Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Merge contextual search facetFilters with config-provided facetFilters.
Remove security: not a big deal because users will notice easily if their search is broken due to an extra useless config filter.
Fixes #3790
Test Plan
preview + locally
Related PRs
#3550