Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix accessibility issue with IconArrow #4011

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 7, 2021

Closes #4010

Motivation

Fix #4010

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Used Accessibility Insights for Web Chrome extension to test for any accessibility issues

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 7, 2021
@natac13 natac13 changed the title bug: fix accessibility issue with IconArrow bug(v2): fix accessibility issue with IconArrow Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

Size Change: -2 B (0%)

Total Size: 26.7 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.83 kB -1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 7, 2021

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: e2e0877

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff73a4bb5c604000727c218

😎 Browse the preview: https://deploy-preview-4011--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 7, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4011--docusaurus-2.netlify.app/classic/

@yangshun yangshun changed the title bug(v2): fix accessibility issue with IconArrow fix(v2): fix accessibility issue with IconArrow Jan 10, 2021
@yangshun yangshun merged commit 2ba55b0 into facebook:master Jan 10, 2021
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jan 11, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar collapse arrow give accessibility error for no alt text or aria-label
5 participants