fix(v2): website editUrl should target upstream docs #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: documentation
slorber
added
pr: maintenance
|
[V1] Deploy preview success Built with commit 02f82ae |
|
Deploy preview for docusaurus-2 ready! Built with commit 02f82ae |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4233--docusaurus-2.netlify.app/classic/ |
|
Size Change: +14 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
slorber
changed the title
slorber
added
CLA Signed
slorber
changed the title
slorber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As I introduced the
editUrlfn, I didn't see I broke the fact that edit buttons should lead to the upstream docs, so we receive doc update PRs to update alpha 70 instead of the docs of the upcoming release.We prefer to receive docs PR to upstream docs, because if the user does not modify the upstream docs, the update will be lost on next release.