Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): make doc container full width when hidden sidebar #4247

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 18, 2021

Motivation

PR #4241 was merged too quickly so I didn't have time to test it as it introduced a small regression for collapsible doc sidebar.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After (centered)
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner February 18, 2021 12:02
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 18, 2021
@netlify
Copy link

netlify bot commented Feb 18, 2021

[V1] Deploy preview success

Built with commit 957f173

https://deploy-preview-4247--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Feb 18, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 957f173

https://deploy-preview-4247--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 65
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4247--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: +14 B (0%)

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB +15 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB -1 B (0%)

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Feb 18, 2021

oh, I see 😓 that's annoying

Not a big deal but the scrollbar appears during the collapsing anim. Wonder if there's an easy way to fix this properly.

Otherwise we can merge this and see later, that does not have a too annoying impact

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 18, 2021
@slorber
Copy link
Collaborator

slorber commented Feb 18, 2021

will merge this for now but if you have a better solution we can revisit

@slorber slorber merged commit 02f7722 into master Feb 18, 2021
@lex111
Copy link
Contributor Author

lex111 commented Feb 18, 2021

Not a big deal but the scrollbar appears during the collapsing anim. Wonder if there's an easy way to fix this properly.

Maybe we can solve this issue if we set the maximum width for code blocks only. How do you like this idea?

@lex111 lex111 deleted the lex111/fix-hidden-docsidebar branch February 19, 2021 18:20
@slorber
Copy link
Collaborator

slorber commented Feb 19, 2021

Not sure, as long as the solution is not too complex and does not involve too much complex calc maths that would likely break over time, open for any suggestion :)

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants