-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): make doc container full width when hidden sidebar #4247
Conversation
[V1] Deploy preview success Built with commit 957f173 |
Deploy preview for docusaurus-2 ready! Built with commit 957f173 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4247--docusaurus-2.netlify.app/classic/ |
Size Change: +14 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
oh, I see 😓 that's annoying Not a big deal but the scrollbar appears during the collapsing anim. Wonder if there's an easy way to fix this properly. Otherwise we can merge this and see later, that does not have a too annoying impact |
will merge this for now but if you have a better solution we can revisit |
Maybe we can solve this issue if we set the maximum width for code blocks only. How do you like this idea? |
Not sure, as long as the solution is not too complex and does not involve too much complex calc maths that would likely break over time, open for any suggestion :) |
Motivation
PR #4241 was merged too quickly so I didn't have time to test it as it introduced a small regression for collapsible doc sidebar.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)