Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1): Fix v1 site deployment with Crowdin again... #4410

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 12, 2021

Motivation

Follow-up of #4396

This PR is a little refactor and mostly used to trigger a v1 site build on CircleCI...

Crowdin has a weird behavior on our v1 site and refuse to upload new versioned source files (even if you use a random filename + random file content).

❌ Project already contains the file 'master/website-1.x/versioned_docs/version-1.14.7/tutorial-create-pages.md'

The workaround is... to upload the files through their UI...

For some reasons, our v2 deployment does not seem affected by this issue.

I've reported the issue to their support, hopefully, they'll be able to fix this.

Note: it's important that all files are uploaded to crowdin otherwise the localized v1 site has missing pages and broken links on localized sites (ie the latest version is not included in the localized sites)

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 12, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 12, 2021
@netlify
Copy link

netlify bot commented Mar 12, 2021

[V1] Deploy preview success

Built with commit 6ce721f

https://deploy-preview-4410--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 6ce721f

https://deploy-preview-4410--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4410--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: 0 B

Total Size: 567 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.3 kB 0 B
website/build/assets/js/main.********.js 393 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.7 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.6 kB 0 B

compressed-size-action

@slorber slorber merged commit fa1d681 into master Mar 12, 2021
@lex111 lex111 added this to the v2.0.0-alpha.72 milestone Mar 15, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
@slorber slorber deleted the slorber/fix-crowdin-deploy-v1-again branch August 17, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants