Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): Add Filipino default translations to theme #4624

Merged
merged 2 commits into from
Apr 16, 2021
Merged

feat(v2): Add Filipino default translations to theme #4624

merged 2 commits into from
Apr 16, 2021

Conversation

gumacahin
Copy link
Contributor

Add default Filipino translations.

Motivation

I used Docusaurus in one of my projects which has a Filipino translation. I decided contribute translations here.

Have you read the Contributing Guidelines on pull requests?

Yes, I did.

Test Plan

None.

Related PRs

None.

Add default Filipino translations.
@facebook-github-bot
Copy link
Contributor

Hi @gumacahin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Apr 16, 2021

[V2]

Built with commit 50ddcb2

https://deploy-preview-4624--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 16, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4624--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 16, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Apr 16, 2021
@slorber slorber changed the title Create fil.json feat(v2): Add Filipino default translations to theme Apr 16, 2021
@netlify
Copy link

netlify bot commented Apr 16, 2021

[V1]

Built with commit 50ddcb2

https://deploy-preview-4624--docusaurus-1.netlify.app

@slorber slorber merged commit 7057461 into facebook:master Apr 16, 2021
@gumacahin gumacahin deleted the patch-1 branch April 16, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants