Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): use aliased path for blog list sidebar file #4860

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented May 28, 2021

Motivation

Resolves #4840

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

In the main.js file try searching for "blog-post-list-prop-default.json" (path must be with ~blog alias)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 28, 2021
@lex111 lex111 requested a review from slorber as a code owner May 28, 2021 09:32
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 28, 2021
@netlify
Copy link

netlify bot commented May 28, 2021

✔️ [V1]

🔨 Explore the source changes: ecb564a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60b0b8a0b737480007bb8d31

😎 Browse the preview: https://deploy-preview-4860--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented May 28, 2021

✔️ [V2]

🔨 Explore the source changes: ecb564a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60b0b8a04397c400080bd50a

😎 Browse the preview: https://deploy-preview-4860--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 67
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4860--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -170 B (0%)

Total Size: 620 kB

Filename Size Change
website/build/assets/js/main.********.js 443 kB -170 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.1 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 26.9 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 2, 2021

LGTM thanks 👍

@slorber slorber merged commit a1c17c7 into master Jun 2, 2021
@slorber slorber deleted the lex111/iss4840 branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build artifact contains absolute path
3 participants