Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): remove deprecated docs option excludeNextVersionDocs #5053

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 24, 2021

Breaking changes:

  • The excludeNextVersionDocs deprecated docs option will now be rejected with a validation error

Motivation

The docs plugin option excludeNextVersionDocs: true has been deprecated with a warning for more than 6 months now, and replaced by includeCurrentVersion: false.

Let's do the cleanup and remove this useless code.

@slorber slorber added pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: polish This PR adds a very minor behavior improvement that users will enjoy. labels Jun 24, 2021
@slorber slorber requested a review from lex111 as a code owner June 24, 2021 16:22
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 24, 2021
@netlify
Copy link

netlify bot commented Jun 24, 2021

✔️ [V2]

🔨 Explore the source changes: 105b9c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60d4b1342ccec200080f121a

😎 Browse the preview: https://deploy-preview-5053--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5053--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 571 kB

ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 87.7 kB
website/build/assets/js/main.********.js 386 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 66.4 kB
website/build/docs/introduction/index.html 235 B
website/build/index.html 31.1 kB

compressed-size-action

@slorber slorber merged commit 05c85c7 into master Jun 24, 2021
@slorber slorber deleted the slorber/remove-docs-excludeNextVersionDocs branch August 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants