Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add Dart Code Metrics site to showcase page #5260

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

incendial
Copy link
Contributor

Motivation

The documentation of Dart Code Metrics is using Docusaurus v2.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.

Related PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 30, 2021
@netlify
Copy link

netlify bot commented Jul 30, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: d9ef94a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/610426a9da6e6a0008f359bd

😎 Browse the preview: https://deploy-preview-5260--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5260--docusaurus-2.netlify.app/

title: 'Dart Code Metrics',
description: 'Static analysis tool that helps analyse and improve Dart code quality.',
preview: require('./showcase/dart-code-metrics.png'),
website: 'https://dartcodemetrics.dev/',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to understand the reason behind adding a forward slash in the url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy pasted the url from the browser url bar. Is it wrong to have it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No just wanted to know, the reason. Both url works the same way, if URLs are being used as a Baseurl in the code somewhere, it depends if they want to join the URI fragments with a slash or without.

@lex111 lex111 merged commit ca88031 into facebook:master Jul 30, 2021
@lex111
Copy link
Contributor

lex111 commented Jul 30, 2021

@incendial it's all right, thanks!

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 30, 2021
@incendial incendial deleted the add-dartcodemetrics-to-showcase branch July 30, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants