-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): add Dart Code Metrics site to showcase page #5260
docs(v2): add Dart Code Metrics site to showcase page #5260
Conversation
✔️ [V2] 🔨 Explore the source changes: d9ef94a 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/610426a9da6e6a0008f359bd 😎 Browse the preview: https://deploy-preview-5260--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5260--docusaurus-2.netlify.app/ |
title: 'Dart Code Metrics', | ||
description: 'Static analysis tool that helps analyse and improve Dart code quality.', | ||
preview: require('./showcase/dart-code-metrics.png'), | ||
website: 'https://dartcodemetrics.dev/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to understand the reason behind adding a forward slash in the url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy pasted the url from the browser url bar. Is it wrong to have it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No just wanted to know, the reason. Both url works the same way, if URLs are being used as a Baseurl in the code somewhere, it depends if they want to join the URI fragments with a slash or without.
@incendial it's all right, thanks! |
Motivation
The documentation of Dart Code Metrics is using Docusaurus v2.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
None