Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install deps for new project via Yarn on Windows properly #5490

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Sep 6, 2021

Motivation

Fix #5466

Currently after #5233 merge dependencies are not install when initializing of new project via Yarn on Windows. This is probably because FORCE_COLOR environment variable is set in command itself, but should be set in env object as second parameter in shell.exec call.
However just in case I use supports-color to make sure that terminal supports colorized output.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Try initialize new Docusaurus project on Windows with Yarn using Command Prompt or Git Bash locally.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Sep 6, 2021
@lex111 lex111 requested a review from slorber as a code owner September 6, 2021 14:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 6, 2021
@netlify
Copy link

netlify bot commented Sep 6, 2021

✔️ [V2]

🔨 Explore the source changes: 139515b

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61362532f000fc00072c7a6d

😎 Browse the preview: https://deploy-preview-5490--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5490--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

Size Change: -6 B (0%)

Total Size: 826 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.7 kB 0 B
website/build/assets/css/styles.********.css 93.9 kB 0 B
website/build/assets/js/main.********.js 414 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB 0 B
website/build/blog/index.html 38.1 kB 0 B
website/build/docs/index.html 44.6 kB -3 B (0%)
website/build/docs/installation/index.html 52.8 kB -3 B (0%)
website/build/index.html 30.8 kB 0 B
website/build/tests/docs/index.html 25.4 kB 0 B
website/build/tests/docs/standalone/index.html 23 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Sep 21, 2021

LGTM, but not really sure how to test this 😅

@Josh-Cena any opinion before merge?

@Josh-Cena
Copy link
Collaborator

The change looks good to me, at least there won't be further regression... Maybe we should also run E2E tests on Windows?

@slorber
Copy link
Collaborator

slorber commented Sep 22, 2021

Going to merge then and we'll see on canary

Maybe we should also run E2E tests on Windows?

Yes makes sense, will add a call to init + start there. I'll probably skip the Verdaccio part though, it's a bit heavy and would lead to a long test (windows tests are already slower...)

@slorber slorber merged commit ebf81b6 into main Sep 22, 2021
@slorber slorber deleted the lex111/iss5466 branch September 22, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add npm install after npx @docusaurus/init@latest init my-website classic
4 participants