Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add unleash to showcase #5546

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Conversation

ivarconr
Copy link
Contributor

@ivarconr ivarconr commented Sep 9, 2021

Motivation

Add Unleash - an open source feature management solution to the showcase page.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

yarn build
yarn serve:website

@facebook-github-bot
Copy link
Contributor

Hi @ivarconr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Sep 9, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: dea327e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6139d597a83a5b00084904b9

😎 Browse the preview: https://deploy-preview-5546--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 86
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5546--docusaurus-2.netlify.app/

@@ -1240,7 +1240,7 @@ const Users: User[] = [
description: 'A feature managment solution.',
preview: require('./showcase/unleash.png'),
website: 'https://docs.getunleash.io/',
source: 'hhttps://github.com/Unleash/unleash/',
source: 'https://github.com/Unleash/unleash/',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍🏼

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 9, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 9, 2021
@lex111 lex111 merged commit 83b0577 into facebook:main Sep 9, 2021
@lex111
Copy link
Contributor

lex111 commented Sep 9, 2021

@ivarconr thanks!

@ivarconr ivarconr deleted the docs/add-user-unleash branch September 9, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants