Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Blogasaurus to showcase #5572

Merged
merged 6 commits into from
Sep 19, 2021
Merged

Conversation

BattleOfPlassey
Copy link
Contributor

Motivation

I created a personal blog using Docusaurus 2 so I thought of adding it to the showcase section.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No changes in code

Related PRs

No related PR

@BattleOfPlassey
Copy link
Contributor Author

@lex111 @slorber Am i missing something here? The preview build is failing for some reason. Pls advise if some change is needed in the PR.

@Josh-Cena
Copy link
Collaborator

@BattleOfPlassey Check the deploy log, you should use .png extension instead of .PNG. I know it sounds too strict (and probably due to inconsiderate settings), but at least for the sake of uniformity you should change it

@netlify
Copy link

netlify bot commented Sep 18, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: cc86f4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6145be93e19b9c0007ea0c22

😎 Browse the preview: https://deploy-preview-5572--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Sep 18, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5572--docusaurus-2.netlify.app/

@BattleOfPlassey
Copy link
Contributor Author

@Josh-Cena Thank you !!
fixed the png error.

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 19, 2021
@lex111 lex111 changed the title Add Blogasaurus docs: add Blogasaurus to showcase Sep 19, 2021
@lex111 lex111 merged commit ceff278 into facebook:main Sep 19, 2021
@lex111
Copy link
Contributor

lex111 commented Sep 19, 2021

@BattleOfPlassey thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants