Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add nanos world docs to showcase #5638

Merged
merged 2 commits into from
Oct 3, 2021
Merged

Conversation

gtnardy
Copy link
Contributor

@gtnardy gtnardy commented Oct 2, 2021

Added nanos world documentation made with docusaurus

@facebook-github-bot
Copy link
Contributor

Hi @gtnardy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@gtnardy gtnardy marked this pull request as ready for review October 2, 2021 10:56
@netlify
Copy link

netlify bot commented Oct 2, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: de0ea19

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61583abcefb5de0008aa90b5

😎 Browse the preview: https://deploy-preview-5638--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5638--docusaurus-2.netlify.app/

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 2, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 changed the title Added nanos world docs docs: add nanos world docs to showcase Oct 3, 2021
@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 3, 2021
@lex111 lex111 merged commit 46ecda7 into facebook:main Oct 3, 2021
@lex111
Copy link
Contributor

lex111 commented Oct 3, 2021

@gtnardy awesome site, thanks!

@slorber
Copy link
Collaborator

slorber commented Oct 5, 2021

great site 👍

you might be interested to track #5624 where @Josh-Cena mentions customizing Sidebar categories to look like GitBook titles, quite similar to what you are doing:

image

@gtnardy
Copy link
Contributor Author

gtnardy commented Oct 5, 2021

hmm interesting, thank you for the tip @slorber !

@Josh-Cena
Copy link
Collaborator

Yep! We are having a very similar battle here https://docs.luxalgo.com/ to provide a Gitbook-like UI. I wonder if I should just publish a Gitbook theme in the future 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants