-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't ignore options.transforms for buble #5677
Conversation
✔️ [V2] 🔨 Explore the source changes: 51eb073 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6165cb7a82b5df0008305149 😎 Browse the preview: https://deploy-preview-5677--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5677--docusaurus-2.netlify.app/ |
Can't figure out the prettier failure.... the format follows the rest of the file and the github action doesn't have any debug output. |
This line clearly exceeds the length of 80 characters |
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Oops, should be: return transform(source, {
...options,
transforms: {asyncAwait: false, ...options.transforms},
}); in the latest Prettier version |
LGTM thanks. I fixed the prettier issue, which unfortunately only show problematic files but no diff |
Would love a release with this :D |
We'll release soon, in the meantime you can use a canary release |
Motivation
Customizing transformer is not possible, which means disabling transforms like classes etc don't work. This is clearly a bug as it works in normal buble, and the options is spread in but not the options.transforms.
Additionally, we default to allowing classes and getter/setters as these are very useful features.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Make sure it doesn't break on classes or getter setters
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)