Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: perform shallow clone during deploy #5748

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

nlfurniss
Copy link
Contributor

Motivation

For large repos with extensive history, running git clone is not a trivial action. Making a shallow clone is more performant and I don't believe a full clone in necessary for deploy to run correctly.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I ran the command locally

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 20, 2021
@netlify
Copy link

netlify bot commented Oct 20, 2021

✔️ [V2]

🔨 Explore the source changes: 7a7c38c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6170140dfc80310008a295e9

😎 Browse the preview: https://deploy-preview-5748--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 20, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 26
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 64

Lighthouse ran on https://deploy-preview-5748--docusaurus-2.netlify.app/

@slorber slorber changed the title chore: perform shallow clone during deploy refactor: perform shallow clone during deploy Oct 20, 2021
@slorber slorber added the pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient. label Oct 20, 2021
@slorber
Copy link
Collaborator

slorber commented Oct 20, 2021

Makes sense, thanks!

@slorber
Copy link
Collaborator

slorber commented Oct 29, 2021

@nlfurniss this introduced a regression, can you help review this PR please?
That looks fine to me but it means we'll fetch the 1-level history of all branches, so slower than your solution

#5827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: performance This PR does not add a new behavior, but existing behaviors will be more memory- / time-efficient.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants