Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove duplicated appId property #5869

Merged
merged 1 commit into from
Nov 4, 2021
Merged

docs: remove duplicated appId property #5869

merged 1 commit into from
Nov 4, 2021

Conversation

juzhiyuan
Copy link
Contributor

Motivation

I notice there has one duplicated property called appId.

Have you read the [Contributing Guidelines on pull requests]

Yes

Test Plan

No

Related PRs

#5632

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 4, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 4, 2021
@netlify
Copy link

netlify bot commented Nov 4, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: d994745

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6183733cca9524000748707a

😎 Browse the preview: https://deploy-preview-5869--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 4, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 98
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5869--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
Noticed this a while ago, forgot to fix it

@Josh-Cena Josh-Cena merged commit 1e7f688 into facebook:main Nov 4, 2021
@juzhiyuan juzhiyuan deleted the patch-1 branch November 4, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants