-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up dev dependency declarations #6055
Conversation
✔️ [V2] 🔨 Explore the source changes: 89c17ca 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61acd2c0fefd0a0007dd7fb4 😎 Browse the preview: https://deploy-preview-6055--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6055--docusaurus-2.netlify.app/ |
@@ -30,7 +30,7 @@ | |||
"url-loader": "^4.1.1" | |||
}, | |||
"devDependencies": { | |||
"@babel/eslint-parser": "^7.15.7", | |||
"@babel/eslint-parser": "^7.16.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while you are at it, can you align "prettier": across packages?
"prettier": "^2.5.0",
packages/create-docusaurus/templates/facebook/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted this PR right before I went out and I planned to merge it on the phone 😄
Still, good catch, I guess I'll do a more serious dependency cleanup when I get back on my computer
Size Change: 0 B Total Size: 656 kB ℹ️ View Unchanged
|
Motivation
Aligned Babel dep versions; moved some dependencies to devDeps; other cleanups. Getting prepared for #6028.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI