Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update webpack-dev-server + fix deprecation warning #6168

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 22, 2021

Motivation

Webpack just deprecated an option that we use onBeforeSetupMiddleware and added a warning: webpack/webpack-dev-server#4129

Fix #6167

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

local, works without any warning

@netlify
Copy link

netlify bot commented Dec 22, 2021

✔️ [V2]

🔨 Explore the source changes: 2b131ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61c37309a38657000882531e

😎 Browse the preview: https://deploy-preview-6168--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6168--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 662 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 40.1 kB
website/build/assets/css/styles.********.css 102 kB
website/build/assets/js/main.********.js 490 kB
website/build/index.html 29.6 kB

compressed-size-action

@slorber slorber merged commit 8f8aa65 into main Dec 22, 2021
@slorber slorber deleted the slorber/update-dev-server-deprecation branch December 22, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
2 participants