Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add eli5 video to home page #6659

Merged
merged 2 commits into from Feb 12, 2022

Conversation

dmitryvinn-fb
Copy link
Contributor

Motivation

Here at Meta Open Source, we've been creating short-form videos to explain Meta OSS projects in the simplest terms possible. We started embedding these videos into project pages as you can see in Hermes home page https://hermesengine.dev/

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

The video plays and can be full-screened - manually tested

Related PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 11, 2022
@Josh-Cena Josh-Cena changed the title Adding eli5 video the home page docs: add eli5 video to home page Feb 11, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 5b0fbc3

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6205f74241511b00087c8163

😎 Browse the preview: https://deploy-preview-6659--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 11, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 83

Lighthouse ran on https://deploy-preview-6659--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: e8930d9

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6205f896900fd200088e4df3

😎 Browse the preview: https://deploy-preview-6659--docusaurus-2.netlify.app

@slorber slorber mentioned this pull request Feb 11, 2022
2 tasks
@slorber
Copy link
Collaborator

slorber commented Feb 11, 2022

Hi @dmitryvinn-fb

We plan to redesign the homepage in #6386

In the meantime, I don't mind adding this ELI5 video to the homepage.

I'd prefer it to appear below user testimonials though, as providing reassurance looks more important to me than adding this video (but I may be wrong, quite subjective)

@yangshun any opinion?

@yangshun
Copy link
Contributor

I think higher up could be fine too so people who don't know what Docusaurus is about can immediately get an answer. Either is fine by me!

@Josh-Cena
Copy link
Collaborator

Supabase puts it right in the banner where we have the jack-in-the-box Slash, so I would agree with putting it above the features as well

@dmitryvinn-fb
Copy link
Contributor Author

Would you do it like this @yangshun? I wouldn't want to replace Docusaurus logo at the very top so this position might be a better one
image

@yangshun yangshun merged commit 472840d into facebook:main Feb 12, 2022
@Josh-Cena
Copy link
Collaborator

@yangshun The merged version still has the video below the features🤦‍♂️ Not sure if you want that strongly.

@yangshun
Copy link
Contributor

Oh oops. I'll tweak it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants