-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add deep dive video for Docusaurus #6687
Conversation
✔️ [V2] 🔨 Explore the source changes: e15f0a7 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/620d83ba3b17fb0008215554 😎 Browse the preview: https://deploy-preview-6687--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6687--docusaurus-2.netlify.app/ |
Two videos side by side in the viewport seems too overwhelming to me. I think the deep dive video should be in the index page of docs rather than on the landing page. Ideally, the video content place in the middle of the page, so that a visitor can first look at the features. WDYT? |
I don't think the deep dive video should be on the homepage. Maybe on the docs intro page or Advanced Guides? |
Same idea here. If it's more informative than promotional, we probably don't want to put it on the front page. However, Jest does have a 1:38:31 talk on their landing page and it doesn't look terrible, considering how they've set up their layout. (Fun thing is, the entire iframe on the Jest website is invisible on mobile. Probably a bug) Edit. No! The Jest video is intentionally invisible on mobile. https://github.com/facebook/jest/blob/ecab294cd5c1653041289b5cf80deea11af40f3f/website/static/css/custom.css#L59-L63 @SimenB Do you know if that's intentional? |
Also not sure it's a good video for efficient marketing on the homepage
I don't think it's deep enough to be on the advanced guides, but on the intro page that looks like a good fit. What about adding this under or above our fast track section? Maybe add a new section like "Video intro"? |
No idea 😀 |
I guess it's to ensure a reasonable scroll distance for mobile? That makes sense, because otherwise you would get a super long scroll as on the Docusaurus site. |
If you land on some better layout here I'm sure we'd be happy to copy that approach for Jest's site as well. I don't think a designer has thought the video section through? At least not with multiple videos. |
/cc @orta who designed the Jest landing page and may have thoughts on the video placement 😀 |
Good design comes out of Orta, so I'd rather follow what the Jest website does😆 |
I'd recommend not having more than one video on the home page. The above the fold aspects really wants to stay focused on pitching the idea of docusaurus - a deep dive reference is a good topic for the learning flow or much further down (for a while we had videos on the TS website at the bottom) |
So the consensus seems to be to move this to the intro docs, probably the "fast track" section, cool. Does it have to be an iframe? Or is a plain link fine? I also noticed Jest has a videos page. Not sure it's linked to from anywhere since I only discovered it through source code, but it can be a scalable solution for Docusaurus as well, if we get more media in the future |
Ergh, it should be in the sidebar somewhere |
Personally I'd add it there: I'd rather order those things by how much time they need. I'd add it under a new "Video Intro" section, also explaining what this video is about and why it's worth watching in 1 or 2 lines. + embedded video player Does anyone disagree? |
Thanks Going to merge and move on for now as it's good enough I'm not 100% convinced this section heading is the best though, maybe we should make it clearer this section is a video, like "Video Intro" or something? If someone want to suggest a better alternative PRs welcome |
Motivation
Following recent update with ELI5 video, I wanted to see if you would be opened to add a longer version of the video to the home page that we presented at the Algolia meetup
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
#6659