Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify how validateOptions is handled #6961

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Every plugin has an options.ts that exports a validateOptions, which then gets re-exported in the index.ts.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 22, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 22, 2022
@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ [V2]

🔨 Explore the source changes: e9aaae2

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6239aee22f94830007a08175

😎 Browse the preview: https://deploy-preview-6961--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 22, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 16
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6961--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ [V2]

🔨 Explore the source changes: 5314032

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6239b2e3f68d3d00081028ea

😎 Browse the preview: https://deploy-preview-6961--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 22, 2022

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 612 kB
website/build/index.html 38.8 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 6e2eb44 into main Mar 22, 2022
@Josh-Cena Josh-Cena deleted the jc/validate-option branch March 22, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants