New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade dependencies #7232
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7232--docusaurus-2.netlify.app/ |
Size Change: +996 B (0%) Total Size: 803 kB
ℹ️ View Unchanged
|
The "critical dependency" error persists 🤔 |
"dependencies": { | ||
"babel-plugin-dynamic-import-node": "2.3.0", | ||
"unified": "^9.2.2" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this is needed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the wrong hoisting order. We need the right versions of unified
. See #6476 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤪
does it change anything to move this as devDependency instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it was already in devDependency, how moving it to dependency changes anything?
Afaik it only impacts if you run yarn install --production
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err, mostly to highlight that it's not there to actually do anything, but just to re-order hoisting. The problem is we don't have comments in package.json so you have to do weird stuff to give something semantics
This PR also fixes the wrong version of
babel-plugin-dynamic-import-node
being hoisted after #7216. See #3734 for more details.