chore(v2): downgrade babel-plugin-dynamic-import-node to 2.3.0

[lex111]

Motivation

As a result #3727 there was one regression - broken import from PWA plugin. This was not noticed right away, because the site was built without any errors (CI passes), but in the deploy logs I saw following:

1:12:43 AM: (undefined) ../packages/docusaurus-plugin-pwa/src/renderReloadPopup.js 6:554-564
1:12:43 AM: Critical dependency: the request of a dependency is an expression

Strangely enough, this is not a fatal error, but just a warning (why?). Anyway, this error was caused by an update of the babel-plugin-dynamic-import-node dependency, so I roll it back to the previous version.

@slorber however, I wonder why this error/warning is raised, perhaps we are using dynamic import incorrectly? (see airbnb/babel-plugin-dynamic-import-node#90)

docusaurus/packages/docusaurus-plugin-pwa/src/renderReloadPopup.js

Line 24 in 9b3da59

const {default: ReloadPopup} = await import(process.env.PWA_RELOAD_POPUP);

Have you read the Contributing Guidelines on pull requests?

Preview.

Test Plan

See Netlify deploy logs for this PR https://app.netlify.com/sites/docusaurus-2/deploys/5fadacdeaea4f30007353674

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

[netlify]

Deploy preview for docusaurus-2 ready!

Built with commit c55023c

https://deploy-preview-3734--docusaurus-2.netlify.app

[slorber]

Yes I think this is the import. that produces the error. Unfortunately, it did not produce any error/warning when we implemented the PWA, and seemed to work fine

I don't think reverting this dep will solve it because it's already reported here so the problem is already released: #3677

Maybe you have to pin the exact version in dependency instead of using a semver range?

[lex111]

Hmm, but that actually solves the problem, current deploy log doesn't have that error anymore, does it?

[slorber]

you are right, so let's merge it and see 👍