Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docusaurus v2: fix i18n url error #8651

Closed
wants to merge 3 commits into from

Conversation

start940315
Copy link

@start940315 start940315 commented Feb 10, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @start940315!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 10, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 8965078
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63e5f3157315080008665858
😎 Deploy Preview https://deploy-preview-8651--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 62 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 81 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Feb 10, 2023

Thanks for the PR, but without a linked issue or a detailed motivation, I'm not really sure what you are achieving. I'll assume you are doing the same as #6731 (i.e. fixing #6462). I'm going to close this because the code obviously doesn't always work as intended, but feel free to send an issue detailing what's wrong with the current behavior.

@Josh-Cena Josh-Cena closed this Feb 10, 2023
@start940315
Copy link
Author

Thanks for the PR, but without a linked issue or a detailed motivation, I'm not really sure what you are achieving. I'll assume you are doing the same as #6731 (i.e. fixing #6462). I'm going to close this because the code obviously doesn't always work as intended, but feel free to send an issue detailing what's wrong with the current behavior.

No, I'm fixing a bug. When I use the framework, after I chose a language, the locale added to the url one by one. I assumed it to be replaced. For example, my locales is ['en', 'zh-Hant', 'zh-Hans'], the initial url is http://localhost:3000/docu/docs/intro, after I chose zh-Hant then chose zh-Hans, the url became http://localhost:3000/zh-Hans/zh-Hant/docu/docs/intro. And I found currentLocale is not updated. So I fixed it locally and submited a pr.

@slorber
Copy link
Collaborator

slorber commented Feb 15, 2023

@start940315 please create a repro showing the problem you are trying to solve: use docusaurus.new for that. We can't check your localhost URLs and inspect what's wrong.

I suspect you have a trailing slash issue leading to this bug, and fixing the trailing slash issue could fix your bug at the same time.

@Josh-Cena
Copy link
Collaborator

@slorber The bug is #8652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants