-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docusaurus v2: fix i18n url error #8651
Conversation
Hi @start940315! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Thanks for the PR, but without a linked issue or a detailed motivation, I'm not really sure what you are achieving. I'll assume you are doing the same as #6731 (i.e. fixing #6462). I'm going to close this because the code obviously doesn't always work as intended, but feel free to send an issue detailing what's wrong with the current behavior. |
No, I'm fixing a bug. When I use the framework, after I chose a language, the locale added to the url one by one. I assumed it to be replaced. For example, my locales is ['en', 'zh-Hant', 'zh-Hans'], the initial url is |
@start940315 please create a repro showing the problem you are trying to solve: use docusaurus.new for that. We can't check your localhost URLs and inspect what's wrong. I suspect you have a trailing slash issue leading to this bug, and fixing the trailing slash issue could fix your bug at the same time. |
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs