Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve sidebar items custom props docs #8888

Merged
merged 4 commits into from Apr 13, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Apr 13, 2023

sidebar_custom_props is of type object and not string

better example for the customProps doc

little bug in ApiTable when clicking on a link inside the table (we should navigate to the link and not to the table row anchor.

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 13, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 13, 2023
@netlify
Copy link

netlify bot commented Apr 13, 2023

[V2]

Name Link
🔨 Latest commit 3b7cdb1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6437d4fc2d0e1600086d4f5f
😎 Deploy Preview https://deploy-preview-8888--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 13, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 90 🟢 97 🟢 92 🟢 100 🟢 90 Report
/docs/installation 🟠 79 🟢 100 🟢 92 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Apr 13, 2023

Size Change: 0 B

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 101 kB
website/build/assets/css/styles.********.css 113 kB
website/build/assets/js/main.********.js 752 kB
website/build/index.html 41.2 kB

compressed-size-action

@slorber slorber changed the title docs: fix sidebar_custom_props api ref doc type docs: improve sidebar items custom props docs Apr 13, 2023
@slorber slorber merged commit 1458689 into main Apr 13, 2023
8 of 9 checks passed
@slorber slorber deleted the slorber/fix-sidebar_custom_props-docs branch April 13, 2023 10:24
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants