fix(debug-plugin): upgrade react-json-view to maintained React-18 compatible fork #9116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
added
the
Argos
|
Size Change: -122 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
slorber
changed the title
3 tasks
|
I don't have a solution in mind, but FYI: @microlink/react-json-view depends on flux which also has peer dependency React ^15.0.2 || ^16.0.0 || ^17.0.0. 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #9105
Need to replace the unmaintained JSON viewer lib in our debug plugin.
Also added a navbar button to easily navigate to the debug view in dev.
For reference, I choose to use the fork from
@microlinkbecause other projects were not immediate project forks and more alternative libs. Also, we already depend on other projects from the same author, such as unavatar. It does not feel necessary to create/maintain our own fork for now, but time will tell.I'm open to replacing it with another different lib later. But for now this fix is good enough.
Test Plan
ci
Test links
Deploy preview: https://deploy-preview-9116--docusaurus-2.netlify.app/