fix(theme): canonical url should be not change after hydration if url accessed with/without trailing slash #9130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
reviewed
Jul 17, 2023
packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
|
LGTM thanks 👍 Did some minor changes considering we have a This PR improves things a bit and is good enough to merge. Note I think we still have an SEO problem when aliasing docs, see #9170 (unfortunately not so easy to fix). |
slorber
changed the title
slorber
added
the
to backport
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
slorber
added a commit
to VinceCYLiao/docusaurus
that referenced
this pull request
Aug 3, 2023
… accessed with/without trailing slash (facebook#9130) Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
slorber
added a commit
that referenced
this pull request
Sep 20, 2023
… accessed with/without trailing slash (#9130) Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
slorber
added a commit
that referenced
this pull request
Sep 20, 2023
…lease (#9324) Co-authored-by: Joshua Chen <sidachen2003@gmail.com> Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com> Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com> Co-authored-by: Ori Shalom <ori-shalom@users.noreply.github.com> Co-authored-by: Mikey O'Toole <mikey@homotechsual.dev> Co-authored-by: TheCatLady <52870424+TheCatLady@users.noreply.github.com> fix flaky screenshots, add html data-has-hydrated attribute (#9256) fix(theme-common): ThemedComponent should display something when JS is disabled (#9243) fix(theme): canonical url should be not change after hydration if url accessed with/without trailing slash (#9130) fix(theme): only set classname on ul elements if they have an existing class (#9099) fix(content-docs): sidebar generator should return customProps for doc items (#9107)
slorber
added
backported
sahandseifi
added a commit
to notificationapi-com/docs
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
I'm not really sure how to test it but we have it on every page of the site so I guess we can say there is a dogfooding...
Motivation
See #9128
Test Plan
Visit a page on the website with a trailing slash in the URL and inspect the canonical link using dev tools.
Then navigate to the same page without a trailing slash and inspect the canonical link using dev tools again.
If both versions of the page have the same URL then the bug is fixed.
Screen.Recording.2023-07-08.at.0.22.43.mov
Test links
Deploy preview: https://deploy-preview-9130--docusaurus-2.netlify.app/
Related issues/PRs
Closes #9128